I've never practiced criminal law and don't litigate but there's a really broad range of competency among lawyers. We have 170+ law schools in the United States and though the bar exams are reasonably well-written, one can take the exam as many times as they need to pass. Taking this further, no matter how well you prepare someone in legal theory and legal reasoning there are people who just don't have common sense, which the bar exam does try to screen for, but not well enough. Trump does not hire talented lawyers and since he's run for President his saving grace has been the protections Presidents get from prosecution, lawsuits, and disclosure in some cases. He's also defended by vast media organs that do public relations work for him gratis and a mob who threatens the people who would investigate or prosecute him.
From what I've read the FBI is going to be fingerprinting the documents taken from Mar-A-Lago to see who has handled them. I don't know how well fingerprints will show up on paper but the idea is that these documents are supposed to only be seen and handled by certain people.
I do worry that people who think there will necessarily have been a plot to sell secrets will be disappointed. We don't have Trump on tape on 1/6 saying "attack the Capitol, overturn the elections, and kill every Democratic Congress person". But I did hear him tell Georgia's Secretary of State that he wants him to find the number of votes he needs to win and that he may have liability if he doesn't. We have to accept that these kinds of actions are often criminal and should be punished. Putting nuclear secrets in a country club storage locker when you're not President and not returning them when demanded should be enough to convict him of a felony.
